Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TraceUtil support versions of cascading older than 2.6 #1180

Merged
merged 1 commit into from
Jan 30, 2015

Conversation

isnotinvain
Copy link
Contributor

This was the original intention, but unfortunately it still triggers trying to load a class that doesn't exist pre 2.6

@isnotinvain
Copy link
Contributor Author

The logs look like this:

15/01/29 23:42:04 WARN scalding.Tracing$: There was an error initializing tracing. Tracing information in DocumentServices such as Driven may point to Scalding code instead of user code. The most likely cause is a mismatch in Cascading library version. Upgrading the Cascading library to at least 2.6 should fix this issue.The cause was [java.lang.ClassNotFoundException: cascading.util.TraceUtil]

So as written, we only get the message of the exception not the full trace. Normally I'd update this to properly log the full stack trace, but given that this message is going to happen a lot / the full trace probably isn't that useful, maybe we should leave it as is?

@ianoc
Copy link
Collaborator

ianoc commented Jan 30, 2015

LGTM merge when green

isnotinvain added a commit that referenced this pull request Jan 30, 2015
Make TraceUtil support versions of cascading older than 2.6
@isnotinvain isnotinvain merged commit 78eabab into develop Jan 30, 2015
@johnynek johnynek deleted the alexlevenson/trace-util-fix branch January 30, 2015 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants