Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a ConcurrentHashMap instead of a WeakHashMap to make the Stats behave in a correct manner #1184

Merged
merged 1 commit into from
Feb 3, 2015

Conversation

vineethvarghese
Copy link
Contributor

This is a fix for #1182

Basically we replace the WeakHashMap with a ConcurrentHashMap to fix the issue.

johnynek added a commit that referenced this pull request Feb 3, 2015
Using a ConcurrentHashMap instead of a WeakHashMap to make the Stats behave in a correct manner
@johnynek johnynek merged commit 858eaa9 into twitter:develop Feb 3, 2015
@avibryant
Copy link
Contributor

The 0.13 release hasn't actually been announced yet AFAICT - can/will this make it in?

@ianoc
Copy link
Collaborator

ianoc commented Feb 3, 2015

The release is cut and on sonatype/maven central... Will need to be 0.13.1

On Monday, February 2, 2015, Avi Bryant notifications@github.com wrote:

The 0.13 release hasn't actually been announced yet AFAICT - can/will this
make it in?


Reply to this email directly or view it on GitHub
#1184 (comment).

@vineethvarghese
Copy link
Contributor Author

@ianoc Do you have a release time frame/plan for 0.13.1?

@ianoc
Copy link
Collaborator

ianoc commented Feb 3, 2015

@isnotinvain is currently pushing out the current release cycle, not sure if he wants to hold of an announce until 0.13.1 or we do it soon after.

@johnynek
Copy link
Collaborator

johnynek commented Feb 3, 2015

Since this is a non-trivial bug-fix, I'd support a 0.13.1 if we can. It
does not take too much time to publish (also Execution.failed #1185 could
get in).

On Tue, Feb 3, 2015 at 9:36 AM, ianoc notifications@github.com wrote:

@isnotinvain https://github.com/isnotinvain is currently pushing out
the current release cycle, not sure if he wants to hold of an announce
until 0.13.1 or we do it soon after.


Reply to this email directly or view it on GitHub
#1184 (comment).

Oscar Boykin :: @posco :: http://twitter.com/posco

@isnotinvain
Copy link
Contributor

I'm doing the 0.13.1 now -- we can do the announcement then

@vineethvarghese
Copy link
Contributor Author

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants