Requires a DateRange's "end" to be after its "start" #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merge when green |
| @@ -73,6 +73,7 @@ object DateRange extends java.io.Serializable { | |||
| */ | |||
| case class DateRange(val start: RichDate, val end: RichDate) { | |||
| import DateOps._ | |||
| require(start <= end) | |||
There was a problem hiding this comment.
An error message here would be nice
require(start <= end, "end of date range must not occur before the start")
|
+1 |
|
Should I add an error message? I just remembered you could do that |
|
Yes; require(start <= end, s"$start is not on or before $end") On Mon, Aug 17, 2015 at 2:10 PM, Ben Pence notifications@github.com wrote:
Oscar Boykin :: @posco :: http://twitter.com/posco |
benpence
added a commit
that referenced
this pull request
Aug 18, 2015
Requires a DateRange's "end" to be after or on its "start"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.