Utility methods for running Executions in parallel #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Execution.from(lock.acquire()) | ||
| .flatMap(_ => e) | ||
| .onComplete { | ||
| case Success(_) => lock.release() |
There was a problem hiding this comment.
Should we not be releasing on success or failure?
|
Why not use scala futures? |
|
@isnotinvain I guess you mean Twitter futures. Answer: the deps are already heavy adding util just to get this method is not worth it. Mo deps mo problems. |
|
Let me know what you guys think, pulled in AsyncSemaphore and made it work with scala futures. Made it private also since I have really only tested it for this use case. I also hopefully came up with a test that stresses the parallelism. |
| case Success((_, p)) => p.release() | ||
| case Failure(_) => () | ||
| } | ||
| .map(_._1.get) |
There was a problem hiding this comment.
rather than map(... get) can we call flatMap(... fromTry( )...)
johnynek
added a commit
that referenced
this pull request
Feb 12, 2016
Utility methods for running Executions in parallel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling this over from the Twitter world. I decided against pulling it the twitter promise library here and instead use the java concurrency library for the locking. Looking at the documents the methods look thread safe.
I am also open to a better name for the for the class. I was going to them on the Execution object but that didn't seem correct.