-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scalding 0.17.2 release #1707
Scalding 0.17.2 release #1707
Conversation
I don't think we need to cherry pick this commit in develop so we? After we publish we need to set Mima to compare to 0.17.2 and I think the version should be 0.17.3-SNAPSHOT. Snapshots should precede the version they represent not follow. |
@johnynek I guess we should cherry-pick changes from |
Yeah it would be nice to have the changes.md updated on develop. We missed that the last couple of times as we've just been updating the rel notes on github. |
Also @ttim you can use the sbt release plugin. I believe that's what @tonyzhoujingtao used for the 0.17.1 release. |
We need to document the steps (I thought we had done that) and maybe even
automate more, if they exist, using `sbt-release`
…On Fri, Jul 14, 2017 at 7:29 AM, Piyush Narang ***@***.***> wrote:
Also @ttim <https://github.com/ttim> you can use the sbt release plugin.
I believe that's what @tonyzhoujingtao
<https://github.com/tonyzhoujingtao> used for the 0.17.1 release.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1707 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEJdgJPmhBt7vJupRskEZozbYo39pkFks5sN6V3gaJpZM4OX0JT>
.
--
P. Oscar Boykin, Ph.D. | http://twitter.com/posco | http://pobox.com/~boykin
|
@johnynek @piyushnarang Will use sbt-release. I've updated our internal doc to reflect usage of sbt-release only for scalding. I've found couple of places with version which should be updated. If everyone is agree I'm going to merge this PR and do 0.17.2 release. |
@@ -34,7 +34,7 @@ package object scalding { | |||
/** | |||
* Make sure this is in sync with version.sbt | |||
*/ | |||
val scaldingVersion: String = "0.17.0" | |||
val scaldingVersion: String = "0.17.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should automate this: we could have the build create a file and we could import that file to get the version (I have seen people do something similar for the git-sha which would also be nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
we should probably make a script that does sed
on the an old version to a new version so we don't always have these issues.
0.17.2
release reverts backward incompatible estimators change and is backward compatible with0.17.0
.In this PR I've set version to
0.17.2
and added changes toCHANGES.md
file. Once merged I'm going to publish jars and tag this commit as0.17.2
release. After that I'm going to set version to0.17.2-SNAPSHOT
and cherry-pick this PR indevelop
branch as well.I've tried to use
git flow
but looks like it doesn't work if you do release not fromdevelop
branch.@piyushnarang @johnynek are you ok with this?