Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalding 0.17.2 release #1707

Merged
merged 2 commits into from
Jul 14, 2017
Merged

Scalding 0.17.2 release #1707

merged 2 commits into from
Jul 14, 2017

Conversation

ttim
Copy link
Collaborator

@ttim ttim commented Jul 14, 2017

0.17.2 release reverts backward incompatible estimators change and is backward compatible with 0.17.0.

In this PR I've set version to 0.17.2 and added changes to CHANGES.md file. Once merged I'm going to publish jars and tag this commit as 0.17.2 release. After that I'm going to set version to 0.17.2-SNAPSHOT and cherry-pick this PR in develop branch as well.

I've tried to use git flow but looks like it doesn't work if you do release not from develop branch.

@piyushnarang @johnynek are you ok with this?

@johnynek
Copy link
Collaborator

I don't think we need to cherry pick this commit in develop so we?

After we publish we need to set Mima to compare to 0.17.2 and I think the version should be 0.17.3-SNAPSHOT. Snapshots should precede the version they represent not follow.

@ttim
Copy link
Collaborator Author

ttim commented Jul 14, 2017

@johnynek I guess we should cherry-pick changes from CHANGES.md.
Version will be 0.17.3 - you are right, actually I was wondering about this.
About mima - yes, you are right here as well, will do after release. Do you think we need separate PRs for that or it's just part of release process so I can just commit this as is?

@piyushnarang
Copy link
Collaborator

Yeah it would be nice to have the changes.md updated on develop. We missed that the last couple of times as we've just been updating the rel notes on github.

@piyushnarang
Copy link
Collaborator

Also @ttim you can use the sbt release plugin. I believe that's what @tonyzhoujingtao used for the 0.17.1 release.

@johnynek
Copy link
Collaborator

johnynek commented Jul 14, 2017 via email

@ttim
Copy link
Collaborator Author

ttim commented Jul 14, 2017

@johnynek @piyushnarang Will use sbt-release. I've updated our internal doc to reflect usage of sbt-release only for scalding.

I've found couple of places with version which should be updated.

If everyone is agree I'm going to merge this PR and do 0.17.2 release.

@@ -34,7 +34,7 @@ package object scalding {
/**
* Make sure this is in sync with version.sbt
*/
val scaldingVersion: String = "0.17.0"
val scaldingVersion: String = "0.17.2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should automate this: we could have the build create a file and we could import that file to get the version (I have seen people do something similar for the git-sha which would also be nice.

Copy link
Collaborator

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

we should probably make a script that does sed on the an old version to a new version so we don't always have these issues.

@ttim ttim merged commit 7a5fe12 into twitter:0.17.x Jul 14, 2017
@ttim ttim deleted the tabishev/0.17.2 branch July 14, 2017 18:53
ttim added a commit to ttim/scalding that referenced this pull request Jul 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants