Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify is it source or sink is absent in mocked sources/sinks #1866

Merged

Conversation

ttim
Copy link
Collaborator

@ttim ttim commented Aug 15, 2018

Recently couple of engineers in Twitter were confused by error message scalding prints in case if test source or sink isn't properly mocked in JobTest.

In this PR I made this message more specific and print either source or sink based on access mode used for this source's tap.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ttim ttim merged commit 74619ff into twitter:develop Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants