-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scalding-cats module for cats typeclasses on scalding types #1890
Conversation
@johnynek could you add some tests code with examples how it will useful for us or more details in description what we will benefit? Thanks. |
@dieu please take a look at the tests. I think giving a how-to is out of scope here. This is for users that wish to interop Execution (and to a much smaller degree TypedPipe) with cats and cats-effect. You might take a look at: https://typelevel.org/cats-effect/datatypes/io.html By implementing Effect for Execution, we can interop with many nice IO related methods. Note, these tests uncovered a bug in the testing framework I reported here: typelevel/cats-effect#441 |
@ianoc can you take a look at this if you have any free time? I was able to make a change to pass the laws without weakening the gens. |
lgtm when green, the cats tests i would think are pretty complete and nice to be able to hook into a lot of them here |
thanks for tests. |
whoops... travis was not actually running the tests... |
Ha woops ! |
We keep implementing local instances of these. This gives the most useful instances for scalding types.
The Execution instances are particularly useful.
@ttim @dieu please take a look.