Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the travis build #944

Merged
merged 5 commits into from
Jul 5, 2014
Merged

Fixes the travis build #944

merged 5 commits into from
Jul 5, 2014

Conversation

ianoc
Copy link
Collaborator

@ianoc ianoc commented Jul 5, 2014

Move up building in scalding to 2.10.4

--> Is backwards compatibility with long file names broken? (Would seem strange since the assembly plugin version should be the same)

--> Cuts down on both the assembly and test noise during build

--> Fixes a scald.rb issue when dealing with 2.10.4, the find_dependencies command appears to return different in 2.10.4

Fixes #943

johnynek added a commit that referenced this pull request Jul 5, 2014
@johnynek johnynek merged commit 127f1d7 into develop Jul 5, 2014
@johnynek johnynek deleted the travisFixTest branch July 5, 2014 19:21
@johnynek
Copy link
Collaborator

johnynek commented Jul 5, 2014

Thanks for digging into this.

Was the 2.10 jar published with 2.10.4?

@ianoc
Copy link
Collaborator Author

ianoc commented Jul 5, 2014

Yeah it was, i'm not sure how this was happening really. sbt ++2.10.3 assembly locally works fine for me.

@johnynek
Copy link
Collaborator

johnynek commented Jul 5, 2014

Hmmm... I have this fear it could be a jdk7-supporting zip64 thing. Hopefully not, because if that is true, running on jdk6 for hadoop 1 will trigger this again.

This is just free-floating anxiety on my part. Probably not the problem. :)

@ianoc
Copy link
Collaborator Author

ianoc commented Jul 5, 2014

Yeah I wondered about that too. Our Travis builds have been set to use jdk7
already though

On Saturday, July 5, 2014, P. Oscar Boykin notifications@github.com wrote:

Hmmm... I have this fear it could be a jdk7-supporting zip64 thing.
Hopefully not, because if that is true, running on jdk6 for hadoop 1 will
trigger this again.

This is just free-floating anxiety on my part. Probably not the problem. :)


Reply to this email directly or view it on GitHub
#944 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scalding tests on travis have gotten two noisey
2 participants