Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExecutionContextJob to interop execution style with Job style #952

Merged
merged 1 commit into from
Jul 10, 2014

Conversation

johnynek
Copy link
Collaborator

@johnynek johnynek commented Jul 7, 2014

Mostly here for showing this is not such a mystery, and to let people slowly adopt the new style, but not change existing launching code.

@jcoveney
Copy link
Contributor

jcoveney commented Jul 7, 2014

This is neat. What's the line between this and a normal Job?

@johnynek
Copy link
Collaborator Author

johnynek commented Jul 7, 2014

I would say that if Job is working for you, that's fine. But Jobs don't compose, whereas Reader[ExecutionContext, T] does compose nicely. So if you are making libraries, the Reader-style can be useful, or if you are calling scalding inside your application.

@johnynek
Copy link
Collaborator Author

johnynek commented Jul 8, 2014

Jesus, Travis is flaky downloading dependencies. They really need to work on a system to share .ivy directories.

ianoc added a commit that referenced this pull request Jul 10, 2014
Add ExecutionContextJob to interop execution style with Job style
@ianoc ianoc merged commit b4b4f7a into develop Jul 10, 2014
@ianoc ianoc deleted the executionjob branch July 10, 2014 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants