Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not inherit from FileSource in LzoTraits #976

Merged
merged 1 commit into from
Jul 26, 2014
Merged

Do not inherit from FileSource in LzoTraits #976

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions scalding-commons/src/main/scala/com/twitter/scalding/commons/source/LzoTraits.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,19 +55,19 @@ trait ErrorThresholdLzoCodec[T] extends ErrorHandlingLzoCodec[T] {
lazy val checkedInversion: CheckedInversion[T, Array[Byte]] = new MaxFailuresCheck(maxErrors)(injection)
}

trait LzoProtobuf[T <: Message] extends FileSource with SingleMappable[T] with TypedSink[T] with LocalTapSource {
trait LzoProtobuf[T <: Message] extends LocalTapSource with SingleMappable[T] with TypedSink[T] {
def column: Class[_]
override def setter[U <:T] = TupleSetter.asSubSetter[T, U](TupleSetter.singleSetter[T])
override def hdfsScheme = HadoopSchemeInstance((new LzoProtobufScheme[T](column)).asInstanceOf[Scheme[_,_,_,_,_]])
}

trait LzoThrift[T <: TBase[_, _]] extends FileSource with SingleMappable[T] with TypedSink[T] with LocalTapSource {
trait LzoThrift[T <: TBase[_, _]] extends LocalTapSource with SingleMappable[T] with TypedSink[T] {
def column: Class[_]
override def setter[U <:T] = TupleSetter.asSubSetter[T, U](TupleSetter.singleSetter[T])
override def hdfsScheme = HadoopSchemeInstance((new LzoThriftScheme[T](column)).asInstanceOf[Scheme[_,_,_,_,_]])
}

trait LzoText extends FileSource with SingleMappable[String] with TypedSink[String] with LocalTapSource {
trait LzoText extends LocalTapSource with SingleMappable[String] with TypedSink[String] {
override def setter[U <: String] = TupleSetter.asSubSetter[String, U](TupleSetter.singleSetter[String])
override def hdfsScheme = HadoopSchemeInstance(new LzoTextLine())
}
Expand Down