Adds support for Counters inside the Execution Monad. #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #972 |
|
closes #980 |
| /** | ||
| * Returns the counters with Group String -> Counter String -> Long | ||
| */ | ||
| def countersOf(map: Map[String, Any]): Option[Try[Map[String, Map[String, Long]]]] = |
There was a problem hiding this comment.
this should just take Any, and not put the .get("counters") inside.
|
red build was due to failed download. Restarted. |
|
Travis is really, really noisey. Between failed jar downloads and spurious errors that look like failed isolation between builds, it is pretty frustrating. |
|
LGTM, merge when green |
johnynek
added a commit
that referenced
this pull request
Jul 30, 2014
Adds support for Counters inside the Execution Monad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See kmeans for an example using counters.