Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hook include of helper to loading of ActionView #272

Merged
merged 2 commits into from
Jul 13, 2016
Merged

hook include of helper to loading of ActionView #272

merged 2 commits into from
Jul 13, 2016

Conversation

koenpunt
Copy link
Contributor

All PRs:

  • Has tests
  • Documentation updated

When using rspec with rails-controller-testing, specs would break due to incorrect load order. More info here: rails/rails-controller-testing#24

When using rspec with rails-controller-testing, specs would break due to incorrect load order. More info here: rails/rails-controller-testing#24
@coveralls
Copy link

coveralls commented Jul 13, 2016

Coverage Status

Changes Unknown when pulling 129720e on koenpunt:patch-1 into * on twitter:master*.

@oreoshake
Copy link
Contributor

🆒. Maybe wrap that in an block that checks if ActiveSupport is defined?

@coveralls
Copy link

coveralls commented Jul 13, 2016

Coverage Status

Changes Unknown when pulling fbb4dc2 on koenpunt:patch-1 into * on twitter:master*.

@oreoshake
Copy link
Contributor

Woot thanks! I'll push a new gem later this week.

@oreoshake oreoshake merged commit 0cc560c into github:master Jul 13, 2016
@oreoshake
Copy link
Contributor

Fixed in 3.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants