This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Add a method to prepare for optimizing FlatMapKeys #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| case _ => false | ||
| } | ||
|
|
||
| def isOutput[P <: Platform[P]](p: Producer[P, Any]): Boolean = p match { |
|
@ryanlecompte how can we fix that? Sadly, the planner/optimizer loses types since otherwise we would need Producer to be an HList (a-la shapeless). TailProducer is not a case class, and is a sealed marker trait on producers that have some result. |
|
@johnynek in that particular case we don't need the type info kept anyway do we? |
|
Well, in this particular case you really only care about the fact that you may have a val neighborFn = { (p: Producer[P, Any]) => p match {
case t: TailProducer[_, _] => Iterable.empty[Producer[P, Any]]
case _ => graph(p)
}
}That would fix the 2.10 warning at least :-) |
Conflicts: summingbird-core/src/main/scala/com/twitter/summingbird/Dependants.scala
| /** Returns true if this node does not directly change the data (does not apply any transformation) | ||
| */ | ||
| def isNoOp[P <: Platform[P]](p: Producer[P, Any]): Boolean = p match { | ||
| case IdentityKeyedProducer(_) => true |
There was a problem hiding this comment.
style points for later: bunch up cases with case A(_) | B(_) => true
sritchie
added a commit
that referenced
this pull request
Oct 24, 2013
Add a method to prepare for optimizing FlatMapKeys
This was referenced Oct 24, 2013
snoble
pushed a commit
to snoble/summingbird
that referenced
this pull request
Sep 8, 2017
…ormanceFix Keeping the notion of lazily calculated heavy hitters, but fixing it to ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.