Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing country flags #265

Open
Vampire opened this issue Dec 12, 2017 · 2 comments
Open

Missing country flags #265

Vampire opened this issue Dec 12, 2017 · 2 comments

Comments

@Vampire
Copy link

Vampire commented Dec 12, 2017

The following reserved ISO-3166-1 country codes do not have the according flag Emoji.
As other reserved country codes have their respective flag included, I'd like to ask for these also being added.

AN (Netherlands Antilles) 馃嚘馃嚦
BU (Burma) 馃嚙馃嚭
CS (Serbia and Montenegro) 馃嚚馃嚫
EZ (Eurozone)
FX (France, Metropolitan) 馃嚝馃嚱
NT (Saudi Arabian鈥揑raqi neutral zone) [maybe half Saudi Arabia, half Iraq] 馃嚦馃嚬
SF (Finland) 馃嚫馃嚝
SU (USSR) 馃嚫馃嚭
TP (East Timor) 馃嚬馃嚨
UK (United Kingdom) 馃嚭馃嚢
YU (Yugoslavia) 馃嚲馃嚭
ZR (Zaire) 馃嚳馃嚪

@Crissov
Copy link
Contributor

Crissov commented Dec 12, 2017

If you went by deprecated region codes in CLDR, i.e. the resource UTS#51 actually references (through LDML), you would have to add DD, QU and YD, but remove UK from that list. You could also add the 2-letter macroregion codes EZ and QO as well as unknown status code ZZ.

Most of these do not make much sense to support, though, because they are aliases for current codes. Emojitwo supports SU, for what it鈥檚 worth. UTS#51 does not recommend any of these for general interchange.

Google鈥檚 Noto Color Emoji font has a white flag with an question mark at some PUA code point. ZZ makes more sense for that. They also display it for all unsupported RIS pairs which results in bad fallback behavior: two letters would usually be better.

@Vampire
Copy link
Author

Vampire commented Dec 13, 2017

  • DD and YD are officially deleted and can be re-assigned, so I'd not add them.
  • QO, QU and ZZ are user-assigned codes so could mean different things, so I'd not add them.
  • Regarding UK and SF, they are both in neither of the sections in the link you provided, but anyway they are exceptionally reserved codes, so I keep them in the list.
  • You are right about EZ though, so I added it to the list.

You are maybe right that most of these are just aliases for other entries, yet in my opinion it would make sense to support them. If you e. g. have a software like Discord, that just searches for the matching file, it cannot show the correct flag without a manual mapping that every user of twemoji would have to implement himself. I think it would make more sense if twemoji just also has these flags present like other reserved cases then the user of the lib does not need to do anything special to use them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants