Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node object is null or undefined #57

Closed
mkaz opened this issue Mar 31, 2015 · 5 comments
Closed

Node object is null or undefined #57

mkaz opened this issue Mar 31, 2015 · 5 comments
Labels

Comments

@mkaz
Copy link

mkaz commented Mar 31, 2015

Received an error from a user running IE9 that is reporting the following bug

screen shot 2015-03-31 at 12 30 05 pm

@WebReflection
Copy link
Contributor

I don't know what is wp-emoji-release.min.js file so I gonna mark this as invalid unless I understand what has this library to do with that.

@mkaz
Copy link
Author

mkaz commented Mar 31, 2015

@WebReflection - sorry for not clarifying that in the initial report. It is simply a bundle of the twemoji.min.js which is being included in the next WordPress 4.2 core release.

The error is being triggered by an undefined node being passed to here:
https://github.com/twitter/twemoji/blob/gh-pages/twemoji.js#L271

My initial thought would be to do a check of the node being undefined and bailing out of that function if that is the case. I can submit a patch if this sounds reasonable.

@WebReflection
Copy link
Contributor

nope, I want to know why that's the case.

I need the exact version of the bundled twemoji.min.js file, hoping that's the latest ( reason there is a CDN ;-) ) and I want the page r document that fails.

I need to know if it fails only in IE9 and eventually why. Having a weak logic in place is not an option, and there should never be a case where subnode is undefined.

I don't want a work around but eventually a proper fix 'casue this library has been battle tested already a lot, nobody mentioned this problem before.

Thanks for collaboration

@WebReflection
Copy link
Contributor

OK this is not really helping.

  • that code is for IE8, I don't see a DOMContentLoaded fallback for modern browsers and IE9
  • that code trusts readyState and invokes load believing that if the emoji library is in, then the document.body must be in too ... very weird logic in there ...
  • I've no idea which version of twemoji you are running there. Can you ensure me that's the last one?
  • I've no idea against which page that thing is loaded
  • I still don't know if it's an IE9 problem only

I won't comment other things that make little sense to me, like new wpEmoji() without a this or a prototoype in the entire file, but in order to accept this bug I need a way to understand what's the problem and reproduce. Thanks

birarda referenced this issue in discord/twemoji Dec 4, 2023
* feat(v15): Add Maracas and Khanda by jyo0329

* Remake maracas SVG with Discord Kevin's help

* Add PNG versions of 1fa87 and 1faaf

* Optimize 1 SVG(s)

---------

Co-authored-by: jdecked <jdecked@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants