Clean up SVG for trans flag #371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Nope, still uses non-overlapping stripes. Even worse, there's this very slight misalignment now which is going to bug me every time I notice it: |
adroitwhiz
force-pushed
the
fix-trans-flag
branch
from
2ec2799
to
f52de14
Compare
|
I rebased this so it can now be merged without conflicts. This also fixes some other issues with slightly crooked stripes (incidentally resulting in slightly smaller files). @jdecked Mind taking a look at this? |
|
@adroitwhiz I've passed this onto our designers to have a look. |
|
@adroitwhiz We believe we've fixed this in v13.0.2. Please reopen/comment if that's inaccurate. |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the stripes for the trans flag emoji are non-overlapping, which leads to small gaps between them when rendered with antialiasing (known as conflation artifacts).
This PR changes that: now the flag consists of a single white rectangle stacked on top of a single taller pink rectangle stacked on top of a single rounded blue rectangle. This overlap method is used on other "stripey" flags to prevent similar artifacts.