Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update portion of README still pointing to MaxCDN #585

Merged
merged 1 commit into from
Jan 10, 2023
Merged

fix: update portion of README still pointing to MaxCDN #585

merged 1 commit into from
Jan 10, 2023

Conversation

stefafafan
Copy link
Contributor

This pull request ( #581 ) replaced links using MaxCDN to unpkg, but the first link in README was still pointing to MaxCDN. So I went ahead and replaced that portion too.

Related: #580

@CLAassistant
Copy link

CLAassistant commented Jan 9, 2023

CLA assistant check
All committers have signed the CLA.

@jd
Copy link

jd commented Jan 10, 2023

This does not seem to solve the issue, as the base URL is still maxcdn.

@stefafafan
Copy link
Contributor Author

I haven't really went through the code much, but this P-R is just an adjustment to the readme which was left behind from the following pull request
#581

@WebReflection WebReflection merged commit d94f4cf into twitter:master Jan 10, 2023
@stefafafan stefafafan deleted the adjust-cdn-readme branch January 10, 2023 10:21
0robustus1 added a commit to 0robustus1/emojicodes that referenced this pull request Jan 10, 2023
@rubber-bird
Copy link

rubber-bird commented Jan 10, 2023

The script delivered on unpkg still contains https://twemoji.maxcdn.com/v/14.0.2/. Is there any chance to be fixed in near future ? 🐰
Screen Shot 2023-01-10 at 11 50 04 AM

@WebReflection
Copy link
Collaborator

somebody needs to push a new version but it's not clear who has rights to do so and until then, you can use the base property to fix your issues, as explained in the issue.

0robustus1 added a commit to 0robustus1/emojicodes that referenced this pull request Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants