redis: handling SCRIPT command

twitter · Oct 21, 2015 · 8158d2e · 8158d2e
1 parent 619b55b
commit 8158d2e
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/src/nc_message.h b/src/nc_message.h
@@ -161,6 +161,7 @@ typedef enum msg_parse_result {
     ACTION( REQ_REDIS_ZSCORE )                                                                      \
     ACTION( REQ_REDIS_ZUNIONSTORE )                                                                 \
     ACTION( REQ_REDIS_ZSCAN)                                                                        \
+    ACTION( REQ_REDIS_SCRIPT )                 /* redis requests - script */                        \
     ACTION( REQ_REDIS_EVAL )                   /* redis requests - eval */                          \
     ACTION( REQ_REDIS_EVALSHA )                                                                     \
     ACTION( REQ_REDIS_PING )                   /* redis requests - ping/quit */                     \

diff --git a/src/proto/nc_redis.c b/src/proto/nc_redis.c
@@ -249,6 +249,8 @@ redis_argn(struct msg *r)
     case MSG_REQ_REDIS_ZREVRANGEBYSCORE:
     case MSG_REQ_REDIS_ZUNIONSTORE:
     case MSG_REQ_REDIS_ZSCAN:
+
+    case MSG_REQ_REDIS_SCRIPT:
         return true;
 
     default:
@@ -316,6 +318,25 @@ redis_argeval(struct msg *r)
     return false;
 }
 
+
+/*
+ * return true if the redis command needs to broadcast to all cluster members.
+ *
+ */
+static bool
+redis_need_bcast(struct msg *r) 
+{
+    switch (r->type) {
+    case MSG_REQ_REDIS_SCRIPT:
+        return true;
+
+    default:
+        break;
+    }
+
+    return false;
+}
+
 /*
  * Return true, if the redis response is an error response i.e. a simple
  * string whose first character is '-', otherwise return false.
@@ -879,6 +900,11 @@ redis_parse_req(struct msg *r)
                     break;
                 }
 
+                if (str6icmp(m, 's', 'c', 'r', 'i', 'p', 't')) {
+                    r->type = MSG_REQ_REDIS_SCRIPT;
+                    break;
+                }
+
                 break;
 
             case 7: