redis-integer-reply

[charsyam]

fixing parsing redis response to accept integer-reply

[charsyam]

@manjuraj please, review this code :)

[manjuraj]

We need to fix this generically. Based on redis.io/topics/protocol "every element of a Multi Bulk Reply can be of any kind, including a nested Multi Bulk Reply". Currently the response parser assumes that every element of the multi bulk reply is a bulk reply and we have to change that

[charsyam]

@manjuraj Yes. you're right. I just think that Multi Bulk reply consists of "String" + "Integer Reply". Thank you.
I will think about it right :)

[manjuraj]

every element of the multi-bulk reply can be integer / bulk / nested multi-bulk reply

[manjuraj]

I think we can just solve it for integer and bulk reply for now; nested multi-bulk reply might be hairy to implement

[charsyam]

@manjuraj I think nested multi-bulk reply is impossible in redis. and multi-bulk just reply can be integer/bulk.
So. I might think this patch can parse redis response right because nested multi-bulk is impossible. :)

[manjuraj]

we need to fix '$-1' cases as bulk element, I believe

[charsyam]

@manjuraj Yes, and we need to fix '*-1' cases also. :)

[charsyam]

@manjuraj in previous code, you already handle "$-1" case :)

[charsyam]

@manjuraj I tested following cases :) and it passed all cases.
Please review this patch :) Thank you

get abc
$-1

mget abc ade ged
*3
$-1
$-1
$-1

eval "return {10,10}" 1 TEMP
*2
:10
:10

blpop key 1 <--- for test, I changed can support this :) only for using one connection.
*-1

[manjuraj]

good job @charsyam