Comment pending Hebrew tailoring specs (script reordering).

twitter · Nov 11, 2013 · 0a9399d · 0a9399d
1 parent 8990956
commit 0a9399d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/lib/twitter_cldr/resources/tailoring_importer.rb b/lib/twitter_cldr/resources/tailoring_importer.rb
@@ -10,8 +10,7 @@
 
 module TwitterCldr
   module Resources
-    # This class should be used with JRuby 1.7 in 1.9 mode and ICU4J version 49.1 (available at
-    # http://download.icu-project.org/files/icu4j/49.1/icu4j-49_1.jar).
+    # This class should be used with JRuby 1.7 in 1.9 mode and ICU4J version >= 49.1.
     #
     class TailoringImporter
 

diff --git a/spec/collation/tailoring_spec.rb b/spec/collation/tailoring_spec.rb
@@ -49,7 +49,7 @@
         else
           failures_info = "#{failures.size} failures: #{failures.inspect}"
           puts failures_info
-          # failures.should(be_empty, "#{locale} - #{failures_info}")  # currently breaks build for Hebrew (he).  Probably should look into this.
+          failures.should(be_empty, "#{locale} - #{failures_info}")
         end
       end
     end

diff --git a/spec/collation/tailoring_tests/he.txt b/spec/collation/tailoring_tests/he.txt
@@ -1,4 +1,7 @@
-# Pending: failures identical to ICU.
+# Pending:
+#   - Failure on line 53 is caused by script reordering (http://site.icu-project.org/design/collation/script-reordering)
+#     that is applied to Hebrew as well as to a few other locales, but is not supported by TwitterCLDR yet.
+#   - Other failures are identical to ICU.
 
 xֽ
 x‎
@@ -48,7 +51,7 @@ X.
 x.x
 x־
 X־
-x־x
+// x־x
 x׳
 X׳
 x׳x