Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Travis CI infrastructure #149

Merged
merged 4 commits into from
Jan 9, 2015
Merged

Use new Travis CI infrastructure #149

merged 4 commits into from
Jan 9, 2015

Conversation

caniszczyk
Copy link
Contributor

This should speed up builds potentially

http://blog.travis-ci.com/2014-12-17-faster-builds-with-container-based-infrastructure/

Signed-off-by: Chris Aniszczyk zx@twitter.com

Signed-off-by: Chris Aniszczyk <zx@twitter.com>
@KL-7
Copy link
Contributor

KL-7 commented Jan 9, 2015

I didn't read through the whole thing yet, but this might be also helpful:

The best news for open source projects is that our build caching is now available for them too. That means faster build speeds by caching dependencies. Make sure to read the docs before trying it out.

For Ruby projects, it's as simple as adding cache: bundler to your .travis.yml.

Signed-off-by: Chris Aniszczyk <zx@twitter.com>
@KL-7
Copy link
Contributor

KL-7 commented Jan 9, 2015

Could you also replace MRI 2.1.0 with 2.2.0? Hopefully it doesn't fail. Also, looks like JRuby and Rubinius are the slowest runtimes in our build. I still think we should keep JRuby, but I'm ok with dropping Rubinius until we hear from someone who's actually using TwitterCLDR on Rubinius.

Signed-off-by: Chris Aniszczyk <zx@twitter.com>
@caniszczyk
Copy link
Contributor Author

Will do!

It definitely looks like the build speeds up significantly with these changes.

@camertron
Copy link
Collaborator

I concur!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.28%) when pulling 00328fd on new-travis-ci into cd6d072 on master.

@KL-7
Copy link
Contributor

KL-7 commented Jan 9, 2015

Oh well, somehow bundler fails to install ruby-cldr on MRI 2.2.0. Feel free to revert it to 2.1.0 and merge, I can look into 2.2.0 issue later.

@camertron
Copy link
Collaborator

We shouldn't even need ruby-cldr when running tests, and it's in the :development group. Can we just do something like bundle --without development?

@KL-7
Copy link
Contributor

KL-7 commented Jan 9, 2015

Looks like removing our custom rubygems installation fixes the issue. I'll update the PR in a second.

FYI, according to this even if you use --without bundler will download the excluded gems.

@KL-7
Copy link
Contributor

KL-7 commented Jan 9, 2015

Whoa, aside from JRuby, the whole build takes less than 5 minutes to run! Thanks for addressing this issue, @caniszczyk.

JRuby still needs some love though (#124).

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) when pulling a06a307 on new-travis-ci into cd6d072 on master.

@caniszczyk
Copy link
Contributor Author

sweet! should we merge this in given that jruby-head is an acceptable failure for now?

KL-7 added a commit that referenced this pull request Jan 9, 2015
Use new Travis CI infrastructure
@KL-7 KL-7 merged commit 3cc9cc8 into master Jan 9, 2015
@KL-7 KL-7 deleted the new-travis-ci branch January 9, 2015 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants