This repository has been archived by the owner on Sep 18, 2021. It is now read-only.
Modify extractUrlsWithIndices() to correctly extract URL w/o protocol in CJK text. #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in extractUrlsWithIndices() to correctly extract URL w/o protocol in CJK text
Current behavior:
extractUrlsWithIndices("twitter.comテストgoogle.com")
=> [{:url=>"twitter.com", :indices=>[0, 25]}]
Only 1st URL is extracted. Also indices incorrect.
Correct behavior:
extractUrlsWithIndices("twitter.comテストgoogle.com")
=> [{:url=>"twitter.com", :indices=>[0, 11]}, {:url=>"google.com", :indices=>[14, 24]}]