This repository has been archived by the owner on Sep 18, 2021. It is now read-only.
Add twttr.txt.modifyIndices{FromUTF16ToUnicode(), FromUnicodeToUTF16()} #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 30, 2012 17:28
…es{FromUTF16ToUnicode, FromUnicodeToUTF16}.
| var c1 = text.charCodeAt(i); | ||
| var c2 = text.charCodeAt(i + 1); | ||
| if (0xD800 <= c1 && c1 <= 0xDBFF && 0xDC00 <= c2 && c2 <= 0xDFFF) { | ||
| // supplementary character |
There was a problem hiding this comment.
An i++ here would make explicit that we have already dealt with the next character as well.
|
LGTM |
keitaf
pushed a commit
that referenced
this pull request
Feb 7, 2012
Add twttr.txt.modifyIndices{FromUTF16ToUnicode(), FromUnicodeToUTF16()}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extract*() in twitter-text-js extracts entities with UTF-16 based indices where Unicode supplementary characters are counted as two characters.
However, Twitter API and twitter-text-rb produces indices based on Unicode where Unicode supplementary characters are counted as single characters.
This will add 2 new methods, twttr.txt.modifyIndicesFromUTF16ToUnicode() and twttr.txt.modifyIndicesFromUnicodeToUTF16(), which can be used to modify indices from UTF-16 based to Unicode based, and vise versa.