Fix bug preventing prefetch data from being loaded if local data was provided #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great changes, looks good to me |
|
The one thing is that this won't do deduplication between the local data and the prefetch data, I think that's ok though. |
|
Yeah, I'm not worried about that. If it's a problem for some people then we can fix it later. |
|
Thanks for catching this and taking care of it. Changes look good to me. On Sun, Feb 24, 2013 at 3:37 PM, Tim Trueman notifications@github.comwrote:
|
jharding
added a commit
that referenced
this pull request
Feb 24, 2013
Fix bug preventing prefetch data from being loaded if local data was provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if local data was provided, the prefetched data would never get loaded. To fix this I refactored dataset.js – there's now a function for processing raw data and a function for merging processed data into the existing
adjacencyListanditemHash.@timtrueman and @vskarich – as soon as I get a 👍 from one of you guys, I"ll merge this into
integration-0.8.1, do some last minute administrative work, and then release v0.8.1 (!).