Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix render with no element #579

Merged
merged 1 commit into from Dec 30, 2013
Merged

Fix render with no element #579

merged 1 commit into from Dec 30, 2013

Conversation

mutewinter
Copy link
Contributor

Looks like this commit got lost in the transition to 0.10.

See #218 and #316

@jharding
Copy link
Contributor

Nice catch. Can you move this check into the _render method just to be careful? Just something like:

if (!this.$el) { return; }

@mutewinter
Copy link
Contributor Author

@jharding changed and it seems to work fine in my app 😄.

jharding added a commit that referenced this pull request Dec 30, 2013
@jharding
Merge pull request #579 from mutewinter/fix_render_with_no_el
33b8359 
Fix render with no element
@jharding jharding merged commit 33b8359 into twitter:integration-0.10.0 Dec 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
v0.10
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mutewinter @jharding