Show dropdown with default suggestions if minLength is 0

[maurizi]

Mostly captures the changes in #390, but updated for typeahead v0.10

Ditches #390's concept of defaultSort since there is now sorting builtin.

[crockpotveggies]

+1 - I hope this can be integrated rather quickly since it's definitely makes typeahead more usable and follows other trends in UI.

[AlleSchonWeg]

It shows the default suggestions, but if you start typing the default suggestions are not filtered.

[meagle]

+1

[jharding]

From the quick glance I just took, seems like a solid pull request. I'll take a closer look when I get a chance and let you know if I feel anything needs to be changed. Thanks for submitting this.

[jharding]

Maybe add SearchIndex#all so that we don't have to reach into the internals of SearchIndex here.

[maurizi]

Done

[maurizi]

@jharding I have some code in this PR to remove the placeholder attribute on the input when the hint is shown, and add it back when the hint is removed.

I was on the fence about doing this or alternatively not showing a hint when the query is empty. Thoughts?

[maurizi]

@Saftpresse99 Do you have an example of this? Maybe you're using different options than what I tested with.

[baslr]

👍 for this feature :)

[snjypl]

+1

[marcusasplund]

+1 for remote. Also maybe think about making triggering configurable? Only on focus might be useful, but annoying in other cases, but one still might want to hook in to the "show all" with e.g. a click-event from whatever. 0.10.* is an awesome rewrite, btw.

[mokesmokes]

Would make sense if the prefetched data can be the default suggestions.

[samleb]

@mokesmokes: agreed, 👍 for this feature in general

[maurizi]

@mokesmokes I've been using it with prefetched data for the default suggestions.

[mokesmokes]

@maurizi Can you please post a usage example? I am porting this project to the Titanium mobile framework, and in the course of that port added an initialData property to the dataset options - probably similar to yours. I also exported readFromStorage from Bloodhound, call that during the Bloodhound initialization done method, and then initialize the typeahead with that initial data in the dataset.

[maurizi]

@mokesmokes The only thing you should need to do to get default suggestions to show up is pass 0 as the minLength option to the typeahead, like so:

    $('#input').typeahead({
        minLength: 0
    }, {
        source: engine.ttAdapter(),
        templates: {
            suggestion: template
        },
    });

[theoephraim]

👍 Looks good!

[yoanisgil]

@maurizi I'm trying to use this feature in my code, but it looks like I'm doing something wrong. This is my code:

    var objects = new Bloodhound({
        datumTokenizer: Bloodhound.tokenizers.obj.whitespace('value'),
        queryTokenizer: Bloodhound.tokenizers.whitespace,
        local: this[collection_name].map(function(obj){
            return {value: obj.get(search_attribute), id: obj.get('id')};
        })
    });

    objects.initialize();

    $(target).find('input').typeahead({
            hint: true,
            highlight: true,
            minLength: 0,
            showDefault: true
        },
        {
            name: 'objects',
            displayKey: 'value',
            source: objects.ttAdapter()
        });

Any idea about what I'm doing wrong?

[maurizi]

@yoanisgil I haven't used this with local, maybe I messed something up.

I'll investigate this as soon as I can and see what's going on.

Though I will say that showDefault isn't necessary or used by this PR, the only thing that should be needed is to have a minLength of 0

[njj]

@maurizi fwiw, I was able to get this to work by extracting some bits of your changes into the current version of typeahead. But when building yours my typeahead failed silently.

[yoanisgil]

I will try to put together a more comprehensive example, but I cannot get this feature to work out of the box. For instance I cloned your typeahead fork and included the bundled file in my project, and that did not work. Seems like I need to build with bower first before I can use it, right?

Le 2014-04-10 à 09:35 PM, Michael Maurizi notifications@github.com a écrit :

@yoanisgil I haven't used this with local, maybe I messed something up.

I'll investigate this as soon as I can and see what's going on.

Though I will say that showDefault isn't necessary or used by this PR, the only thing that should be needed is to have a minLength of 0

—
Reply to this email directly or view it on GitHub.

[maurizi]

@yoanisgil Did you run grunt to rebuild the bundled files? Per the project standards, I didn't rebuild the files in dist/

[yoanisgil]

No, I did not … but I’m also knew to grunt. Will do that and see what comes up.

Will keep you posted.
Le 2014-04-10 à 11:37 PM, Michael Maurizi notifications@github.com a écrit :

@yoanisgil Did you run grunt to rebuild the bundled files? Per the project standards, I didn't rebuild the files in dist/

—
Reply to this email directly or view it on GitHub.

[njj]

@yoanisgil should be able to run npm install then grunt.

[andrezimpel]

+1

[nickmerwin]

+1

[91bananas]

+1

[san7hos]

Any chance that this is getting released any time soon (say 1 month period)?

[JoryUK]

I have manually made these same changes (from azavea's branch) to 10.5 and it works like a charm.
I'm surprised its taken so long to fix this issue / implement this feature one way or another

[dessita]

+1

[roberttdev]

+1

[dessita]

Any chance these merge conflict to get resolved anytime soon?

[ksimuk]

👍

[fgravin]

Is there a simple hack to implement like it was the case in previous version (on click event)

$('input.tt-query').on('click', function() {           

   ...               

  $.each(ttView.datasets[0].itemHash, function(i, item) {
       fullSuggestionList.push(item);
  });

  ttView.dropdownView.renderSuggestions(
      ttView.datasets[0], fullSuggestionList);
  ttView.inputView.setHintValue('');
  ttView.dropdownView.open();

   ...

[vectart]

+1

[dhendo]

+1 - it would be good to provide an unfiltered list on downKeyed for discoverability purposes

[asaarnak]

+1

[alemangui]

Just a small hackish way to accomplish this for those still struggling:

$('.typeahead-input').on( 'focus', function() {
    if($(this).val() === '') // you can also check for minLength
        $(this).data().ttTypeahead.input.trigger('queryChanged', '');
});

[powange]

+1

[ghost]

+1

[ageorgousakis]

+1

[jlbooker]

+1 👍 Would also like to use this to show previous searches when the input element receives focus.

[jharding]

v0.11 just shipped and it adds support for displaying the menu when minLength === 0. Check this example out for more detail.

[91bananas]

#praisejesus

—
David Cushman | TopOPPS

On Sat, Apr 25, 2015 at 3:32 AM, Jake Harding notifications@github.com
wrote:

Closed #719.

Reply to this email directly or view it on GitHub:
#719 (comment)