Skip to content

Commit

Permalink
Avoid deprecated com.twitter.conversions
Browse files Browse the repository at this point in the history
Problem

In phab D249403 these conversions were deprecated.

Solution

Use the new versions.

JIRA Issues: CSL-7356

Differential Revision: https://phabricator.twitter.biz/D254765
  • Loading branch information
kevinoliver authored and jenkins committed Dec 19, 2018
1 parent 9998019 commit c4c33a3
Show file tree
Hide file tree
Showing 61 changed files with 63 additions and 63 deletions.
4 changes: 2 additions & 2 deletions README.md
Expand Up @@ -43,7 +43,7 @@ val collUtils = "com.twitter" %% "util-collection" % "18.12.0"
## Time

```scala
import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._

val duration1 = 1.second
val duration2 = 2.minutes
Expand All @@ -64,7 +64,7 @@ amount.inKilobytes // => 8192L
A Non-actor re-implementation of Scala Futures.

```scala
import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import com.twitter.util.{Await, Future, Promise}

val f = new Promise[Int]
Expand Down
4 changes: 2 additions & 2 deletions doc/src/sphinx/util-cookbook/basics.rst
Expand Up @@ -85,7 +85,7 @@ Scala:

.. code-block:: scala
import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import com.twitter.util.{FuturePool, Time}
val time = Time.fromMilliseconds(123456L)
Expand Down Expand Up @@ -135,7 +135,7 @@ Scala:

.. code-block:: scala
import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import com.twitter.util.{Future, MockTimer, Time}
Time.withCurrentTimeFrozen { timeControl =>
Expand Down
2 changes: 1 addition & 1 deletion util-app/src/main/scala/com/twitter/app/App.scala
@@ -1,6 +1,6 @@
package com.twitter.app

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import com.twitter.util._
import java.lang.reflect.InvocationTargetException
import java.util.concurrent.ConcurrentLinkedQueue
Expand Down
2 changes: 1 addition & 1 deletion util-app/src/test/scala/com/twitter/app/AppTest.scala
@@ -1,7 +1,7 @@
package com.twitter.app

import com.twitter.app.LoadService.Binding
import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import com.twitter.util._
import java.util.concurrent.ConcurrentLinkedQueue
import org.scalatest.FunSuite
Expand Down
2 changes: 1 addition & 1 deletion util-app/src/test/scala/com/twitter/app/FlagTest.scala
@@ -1,7 +1,7 @@
package com.twitter.app

import com.twitter.app.SolarSystemPlanets._
import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import com.twitter.util.{Await, Awaitable}
import org.scalatest.FunSuite
import scala.collection.mutable
Expand Down
@@ -1,7 +1,7 @@
package com.twitter.app

import com.twitter.app.LoadService.Binding
import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import com.twitter.finagle.util.loadServiceDenied
import com.twitter.util.registry.{Entry, GlobalRegistry, SimpleRegistry}
import com.twitter.util.{Await, Future, FuturePool}
Expand Down
@@ -1,6 +1,6 @@
package com.twitter.concurrent

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import com.twitter.util.{Await, Future, StdBenchAnnotations}
import org.openjdk.jmh.annotations._

Expand Down
@@ -1,6 +1,6 @@
package com.twitter.util

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import java.util.concurrent.TimeUnit
import org.openjdk.jmh.annotations._

Expand Down
2 changes: 1 addition & 1 deletion util-cache/src/main/scala/com/twitter/cache/Refresh.scala
Expand Up @@ -17,7 +17,7 @@ import java.util.concurrent.atomic.AtomicReference
* def getData(): Future[T] = { ... }
*
* can be memoized with a TTL of 1 hour as follows:
* import com.twitter.conversions.time._
* import com.twitter.conversions.DurationOps._
* import com.twitter.cache.Refresh
* val getData: () => Future[T] = Refresh.every(1.hour) { ... }
*/
Expand Down
@@ -1,6 +1,6 @@
package com.twitter.cache

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import com.twitter.util.{Await, Future}
import org.scalatest.FunSuite

Expand Down
@@ -1,6 +1,6 @@
package com.twitter.cache

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import com.twitter.util.{Await, Future, Promise, Time}
import org.mockito.Mockito._
import org.scalatest._
Expand Down
Expand Up @@ -4,7 +4,7 @@ import org.junit.runner.RunWith
import org.scalatest.FunSuite
import org.scalatest.junit.JUnitRunner

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import com.twitter.util.{Duration, Time}

@RunWith(classOf[JUnitRunner])
Expand Down
2 changes: 1 addition & 1 deletion util-core/src/main/scala/com/twitter/util/Duration.scala
Expand Up @@ -289,7 +289,7 @@ private[util] object DurationBox {
* using the time conversions:
*
* {{{
* import com.twitter.conversions.time._
* import com.twitter.conversions.DurationOps._
*
* 3.days+4.nanoseconds
* }}}
Expand Down
@@ -1,7 +1,7 @@
package com.twitter.concurrent

import com.twitter.util._
import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import java.util.concurrent.{RejectedExecutionException, CancellationException}
import org.junit.runner.RunWith
import org.scalatest.FunSuite
Expand Down
@@ -1,6 +1,6 @@
package com.twitter.concurrent

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import com.twitter.util._
import java.util.concurrent.{ConcurrentLinkedQueue, RejectedExecutionException}
import org.junit.runner.RunWith
Expand Down
@@ -1,6 +1,6 @@
package com.twitter.concurrent

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import com.twitter.util._
import org.junit.runner.RunWith
import org.scalacheck.{Arbitrary, Gen}
Expand Down
Expand Up @@ -8,7 +8,7 @@ import org.scalatest.WordSpec
import org.scalatest.junit.JUnitRunner
import org.scalatest.mockito.MockitoSugar

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import com.twitter.util.{Await, Future, MockTimer, Promise, Return, Time}

class SimpleOffer[T](var futures: Stream[Future[Tx[T]]]) extends Offer[T] {
Expand Down
@@ -1,6 +1,6 @@
package com.twitter.concurrent

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import com.twitter.util.{Promise, Await}
import org.junit.runner.RunWith
import org.scalatest.FunSuite
Expand Down
@@ -1,6 +1,6 @@
package com.twitter.concurrent

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import org.junit.runner.RunWith
import org.scalatest.FunSuite
import org.scalatest.junit.JUnitRunner
Expand Down
@@ -1,6 +1,6 @@
package com.twitter.concurrent

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import com.twitter.util._
import java.util.concurrent.{Executors, TimeUnit}
import java.util.logging.{Handler, Level, LogRecord}
Expand Down
@@ -1,7 +1,7 @@
package com.twitter.concurrent

import com.twitter.concurrent.Spool.{*::, seqToSpool}
import com.twitter.conversions.time.intToTimeableNumber
import com.twitter.conversions.DurationOps._
import com.twitter.util.{Await, Future, Promise, Return, Throw}
import java.io.EOFException
import org.junit.runner.RunWith
Expand Down
@@ -1,6 +1,6 @@
package com.twitter.io

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import com.twitter.util.{Await, Future}
import org.junit.runner.RunWith
import org.scalatest.FunSuite
Expand Down
@@ -1,6 +1,6 @@
package com.twitter.io

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import com.twitter.util.{Await, FuturePool}
import java.io.ByteArrayInputStream
import org.junit.runner.RunWith
Expand Down
2 changes: 1 addition & 1 deletion util-core/src/test/scala/com/twitter/io/PipeTest.scala
@@ -1,6 +1,6 @@
package com.twitter.io

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import com.twitter.io.ReaderDiscardedException
import com.twitter.util.{Await, Future, Return}
import org.scalatest.{FunSuite, Matchers}
Expand Down
Expand Up @@ -2,7 +2,7 @@ package com.twitter.io

import com.twitter.concurrent.AsyncStream
import com.twitter.conversions.StorageUnitOps._
import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import com.twitter.util.{Future, Return, Await, Throw}
import java.io.ByteArrayInputStream
import org.scalatest.FunSuite
Expand Down
2 changes: 1 addition & 1 deletion util-core/src/test/scala/com/twitter/io/ReaderTest.scala
@@ -1,7 +1,7 @@
package com.twitter.io

import com.twitter.concurrent.AsyncStream
import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import com.twitter.conversions.StorageUnitOps._
import com.twitter.util.{Await, Awaitable, Future, Promise}
import java.io.{ByteArrayInputStream, ByteArrayOutputStream}
Expand Down
2 changes: 1 addition & 1 deletion util-core/src/test/scala/com/twitter/io/WriterTest.scala
@@ -1,6 +1,6 @@
package com.twitter.io

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import com.twitter.util.{Await, Future, Promise}
import java.io.{ByteArrayOutputStream, OutputStream}
import org.scalatest.{FunSuite, Matchers}
Expand Down
Expand Up @@ -62,7 +62,7 @@ class ActivitySourceTest extends FunSuite with BeforeAndAfter {

test("FilePollingActivitySource") {
Time.withCurrentTimeFrozen { timeControl =>
import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
implicit val timer = new MockTimer
val file = new FilePollingActivitySource(1.microsecond, FuturePool.immediatePool)
val buf = file.get(tempFile)
Expand Down
@@ -1,6 +1,6 @@
package com.twitter.util

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import org.scalatest.FunSuite

class ClosableOnceTest extends FunSuite {
Expand Down
@@ -1,6 +1,6 @@
package com.twitter.util

import com.twitter.conversions.time.intToTimeableNumber
import com.twitter.conversions.DurationOps._
import org.junit.runner.RunWith
import org.scalatest.FunSuite
import org.scalatest.concurrent.{Eventually, IntegrationPatience}
Expand Down
@@ -1,6 +1,6 @@
package com.twitter.util

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import org.junit.runner.RunWith
import org.scalatest.FunSuite
import org.scalatest.junit.JUnitRunner
Expand Down
Expand Up @@ -16,7 +16,7 @@

package com.twitter.util

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import java.util.concurrent.TimeUnit
import org.junit.runner.RunWith
import org.scalatest.junit.JUnitRunner
Expand Down
@@ -1,6 +1,6 @@
package com.twitter.util

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import java.util.concurrent.{Future => JFuture, _}
import org.junit.runner.RunWith
import org.scalatest.FunSuite
Expand Down
2 changes: 1 addition & 1 deletion util-core/src/test/scala/com/twitter/util/FutureTest.scala
@@ -1,6 +1,6 @@
package com.twitter.util

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import java.util.concurrent.ConcurrentLinkedQueue
import java.util.concurrent.atomic.AtomicInteger
import org.mockito.Matchers.any
Expand Down
@@ -1,6 +1,6 @@
package com.twitter.util

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import java.util.concurrent.atomic.AtomicInteger
import java.util.concurrent.{TimeUnit, CountDownLatch => JavaCountDownLatch}
import org.junit.runner.RunWith
Expand Down
2 changes: 1 addition & 1 deletion util-core/src/test/scala/com/twitter/util/PoolTest.scala
Expand Up @@ -6,7 +6,7 @@ import org.junit.runner.RunWith
import org.scalatest.WordSpec
import org.scalatest.junit.JUnitRunner

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._

@RunWith(classOf[JUnitRunner])
class PoolTest extends WordSpec {
Expand Down
@@ -1,6 +1,6 @@
package com.twitter.util

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import org.junit.runner.RunWith
import org.scalatest.FunSuite
import org.scalatest.junit.JUnitRunner
Expand Down
@@ -1,6 +1,6 @@
package com.twitter.util

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import org.scalatest.FunSuite
import scala.collection.mutable

Expand Down
2 changes: 1 addition & 1 deletion util-core/src/test/scala/com/twitter/util/TimeTest.scala
Expand Up @@ -10,7 +10,7 @@ import org.scalatest.concurrent.{Eventually, IntegrationPatience}
import org.scalatest.junit.JUnitRunner
import org.scalatest.prop.GeneratorDrivenPropertyChecks

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._

trait TimeLikeSpec[T <: TimeLike[T]] extends WordSpec with GeneratorDrivenPropertyChecks {
val ops: TimeLikeOps[T]
Expand Down
2 changes: 1 addition & 1 deletion util-core/src/test/scala/com/twitter/util/TimerTest.scala
@@ -1,6 +1,6 @@
package com.twitter.util

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import java.util.concurrent.{CancellationException, ExecutorService}
import java.util.concurrent.atomic.AtomicInteger
import org.junit.runner.RunWith
Expand Down
Expand Up @@ -3,7 +3,7 @@ package com.twitter.util
import org.junit.runner.RunWith
import org.scalatest.FunSuite
import org.scalatest.junit.JUnitRunner
import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._

@RunWith(classOf[JUnitRunner])
class TokenBucketTest extends FunSuite {
Expand Down
@@ -1,6 +1,6 @@
package com.twitter.util

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import org.junit.runner.RunWith
import org.scalatest.FunSuite
import org.scalatest.junit.JUnitRunner
Expand Down
2 changes: 1 addition & 1 deletion util-jvm/src/main/scala/com/twitter/jvm/CpuProfile.scala
Expand Up @@ -6,7 +6,7 @@ import java.nio.{ByteBuffer, ByteOrder}

import scala.collection.mutable

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import com.twitter.util.{Duration, Future, Promise, Stopwatch, Time}

/**
Expand Down
2 changes: 1 addition & 1 deletion util-jvm/src/main/scala/com/twitter/jvm/GcPredictor.scala
@@ -1,6 +1,6 @@
package com.twitter.jvm

import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import com.twitter.util.{Duration, Time, Timer}

/**
Expand Down
2 changes: 1 addition & 1 deletion util-jvm/src/main/scala/com/twitter/jvm/Hotspot.scala
@@ -1,7 +1,7 @@
package com.twitter.jvm

import com.twitter.conversions.StorageUnitOps._
import com.twitter.conversions.time._
import com.twitter.conversions.DurationOps._
import com.twitter.util.Time
import java.lang.management.ManagementFactory
import java.util.logging.{Level, Logger}
Expand Down

0 comments on commit c4c33a3

Please sign in to comment.