zk-omni-dump: zk+fle+zab sniffer with automatic port detection #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tring these bytes were unexpectedly prepended to config string - int32 Notification.CURRENTVERSION - int32 configData.length
…tring these bytes were unexpectedly prepended to config string - int32 Notification.CURRENTVERSION - int32 configData.length
…handle_message(), message_from_packet().
…is useful for JUnit testcases where ports are randomly assigned. usage: $ zk-omni-dump $ ant -Dtestcase=ReconfigRecoveryTest -D test.method=testCurrentObserverIsParticipantInNewConfig test-core-java port detection: First of all, zk-omni-dump tries to detect FLE.Initial. This detection is easy because structure of FLE.Initial is very simple. Then zk-omni-dump learns FLE port and tries to detect FLE.Notification. After zk-omni-dump detected FLE.Notification, it parses quorum config string and learn all the ports. TODO: ignore four-letter packets
|
Thanks for the pull request @AkihiroSuda ! This generally looks great, only one small nit in AkihiroSuda@fb07a1d with regards to using ABCMeta as a parent of base class (so @AbstractMethod can be enforced). Other than that, it's good to be merged. Thanks! |
rgs1
added a commit
that referenced
this pull request
Jul 16, 2015
zk-omni-dump: zk+fle+zab sniffer with automatic port detection
|
Merged, thanks @AkihiroSuda ! |
|
@rgs1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zk-omni-dump: zk+fle+zab sniffer with automatic port detection
this is useful for JUnit testcases where ports are randomly assigned.
example usage:
for further information, please refer to
zk-omni-dump --helpandtest_omni.py.port detection:
First of all, zk-omni-dump tries to detect FLE.Initial. This detection is easy because structure of FLE.Initial is very simple.
Then zk-omni-dump learns FLE port and tries to detect FLE.Notification.
After zk-omni-dump detected FLE.Notification, it parses quorum config string in the FLE.Notification packet and learn all the ports.
TODO: