Make bytes optional #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raul Gutierrez Segales <rgs@itevenworks.net>
We have a use case in which we only care about the number of requests, but not the total sizes. This makes this accounting optional. The next step is to wire this up from stats_daemon.py.
rgs1
force-pushed
the
make-bytes-optional
branch
2 times, most recently
from
2ed0805
to
313843a
Compare
This new flag is useful when you want to reduce the number of exported metrics via /json/paths. With it, only number of requests per path and type will be exported.
rgs1
force-pushed
the
make-bytes-optional
branch
4 times, most recently
from
3026032
to
a8cba47
Compare
Some requests have no paths associated (i.e.: Connect). While others might have multiple paths (i.e.: SetWatches). For consistency, if the path is not set treat it as /.
rgs1
force-pushed
the
make-bytes-optional
branch
from
a8cba47
to
d47ccf4
Compare
Signed-off-by: Raul Gutierrez Segales <rgs@itevenworks.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.