support capture zk packet from loopback device and ignore null packet #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sel-fish
commented
Jan 3, 2017
sel-fish
commented
- support capture zk packet from loopback device
- ignore packet which has no user data
Yasumoto
reviewed
Jan 3, 2017
| @@ -221,13 +221,14 @@ def handle_packet(self, packet): | |||
| message = self.message_from_packet(packet) | |||
| self.handle_message(message) | |||
| except (BadPacket, StringTooLong, DeserializationError, struct.error) as ex: | |||
| print("got: %s" % str(ex)) | |||
There was a problem hiding this comment.
I think it's only intended to be verbose if the config is set to dump out "bad packets" so mind deleting this?
There was a problem hiding this comment.
@Yasumoto sorry for that, forgot to remove the debug message. fix it already.
|
Thanks @sel-fish ! |
|
@Yasumoto the honor is mine :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.