zab-dump: support capture zk packet from loopback device and ignore null packet #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sel-fish
commented
Jun 7, 2017
sel-fish
commented
- zab-dump: support capture zk packet from loopback device and ignore null packet
- add .idea to .gitignore
|
Howdy @sel-fish ! Thanks so much for the PR! Do you mind signing the License Agreement? @rgs1 and I lost merge permissions, but we've reached out to some folks at Twitter OSS to look at getting this merged in. Thanks! |
|
Hi @Yasumoto |
|
merged, thanks @sel-fish ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.