Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the library support horizontal lazy load out of the box ? #239

Closed
Sara2009 opened this issue Jun 6, 2019 · 6 comments
Closed

Does the library support horizontal lazy load out of the box ? #239

Sara2009 opened this issue Jun 6, 2019 · 6 comments

Comments

@Sara2009
Copy link

Sara2009 commented Jun 6, 2019

In the readme.md the props offset says it supports horizontal lazyload and we can set it as an array. But in the source code, there is no method to judge the horizontal scroll visible? Is there is something wrong or am I missing something?

@chrisdopuch
Copy link

I'm building a horizontally scrollable image gallery, and I'm finding that the lazy loading does not work (all images get loaded at once, even ones that are fully off the screen). I will try using the preventLoading prop, but it would be great if this "just worked" out of the box.

@chrisdopuch
Copy link

Looks like this issue is still open, so that's officially a "no" on horizontal scrolling:
#56

This can probably be closed as duplicate @Sara2009 , I hope that it gets implemented soon! 🤞

@ameerthehacker
Copy link
Collaborator

@chrisdopuch @Sara2009 #231 PR added it and it is already published

@chrisdopuch
Copy link

Amazing! Thanks @ameerthehacker , I guess the other ticket should get closed then. So happy to hear this! ❤️

@ameerthehacker
Copy link
Collaborator

Thanks, @chrisdopuch I have closed the ticket #56

@ttmthanh
Copy link

I set offset but seem it does not work with horizontal list :'(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants