Add feature to have horizontal lazy-load #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(Lazyload): add horizontal viewport observer.
|
Starving for this PR merge 😃 |
|
@ameerthehacker is there any chance to merge this PR? I think horizontal support is one the top missing features in this great lib. Thank you. |
|
Nope @svobik7, it looks great @ianwensink Thanks for the contribution, will push a release by this weekend! |
|
@svobik7, @ianwensink can anyone of you create a pull request for updating the docs? |
|
Here #233 it is @ameerthehacker. When would you publish new release, please? |
|
@ameerthehacker, waiting for horizontal lazy-load feature. Please publish new release. |
|
@ianwensink, @svobik7, @MandeepKalkhanda , @jasonslyvia, @twobin a new release 2.6.1 has been released to npm which contains support for horizontal scrolling and docks related to the same. |
|
awesome, finally it happens in 2019! |
This was referenced Jul 12, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add a way to horizontally lazy-load items. This is useful for instance, when working with a carousel.
Also, it fixes an error when using SSR frameworks like Next or react-tree-walker. They offer a way to unmount components on server, which causes react-lazyload to throw a lot of error since window is used in the componentWillUnmount.