Fix CI Tests #160
Merged
Fix CI Tests #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmanuelgautier
force-pushed
the
fix-ci-tests
branch
from
7df0f00
to
0e92e34
Compare
|
Cool, thanks for your contribution! |
jasonslyvia
reviewed
Feb 12, 2018
test/karma.conf.js
Outdated
| @@ -113,7 +119,7 @@ module.exports = function (config) { | |||
|
|
|||
| // Continuous Integration mode | |||
| // if true, Karma captures browsers, runs the tests and exits | |||
| singleRun: false, | |||
| singleRun: true, | |||
There was a problem hiding this comment.
I'd like to keep singleRun as false since we change this option via npm scripts when running CI.
There was a problem hiding this comment.
Yes, a test forgotten. It's now fixed.
emmanuelgautier
force-pushed
the
fix-ci-tests
branch
from
0e92e34
to
36d0449
Compare
|
Do you intend on merging this? |
|
@stevemk14ebr I don't see a reason why not :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in title, CI tests failed caused by wrong karma configuration