Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loginWindowBackgroundImageURL image should be cached if not a file:// URL #72

Closed
macprince opened this issue Apr 26, 2023 · 8 comments
Closed
Assignees
Labels
question Further information is requested
Milestone

Comments

@macprince
Copy link

I have the loginWindowBackgroundImageURL in XCreds configured to a URL on a web server. I've noticed that if the network is still coming up when XCreds Login is coming up, it can't reach the web server and the default image is used instead.
Could XCreds cache the image from this URL and reference the cached file if the URL is not reachable when XCreds Login loads?

@twocanoes twocanoes self-assigned this May 31, 2023
@twocanoes twocanoes modified the milestones: XCreds 3.1, XCreds 3.2 May 31, 2023
@twocanoes
Copy link
Owner

is this still wanted given that the default image is now macOS default? The easiest way to implement is just just have a the image as data in the config profile.

@twocanoes twocanoes modified the milestones: XCreds 3.2, XCreds Future Dec 11, 2023
@twocanoes twocanoes added the question Further information is requested label Dec 11, 2023
@macprince
Copy link
Author

@twocanoes Not entirely sure what you mean by this. I need to embed the image in the config profile?

@twocanoes
Copy link
Owner

yes, nomad did this. you put in as base64. would that suffice?

@twocanoes
Copy link
Owner

case BackgroundImage
/// An image to display as the background image as a Base64 encoded `String`.

@twocanoes
Copy link
Owner

it is isn't defined but it does work.

@twocanoes
Copy link
Owner

please test and reopen if it is doesn't work for you.

@macprince
Copy link
Author

Embedding the image itself in the config profile isn't really the solution I'm looking for. By defining a URL to the image, I can change the image easily on the web server and have all of the clients get it from there. I don't know what my MDM's file size limit for uploaded profiles is, and I'd have to base64 encode the image any time I want to change it.
Is caching the image retrieved from the defined URL a troublesome thing to implement?

@twocanoes
Copy link
Owner

implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants