Exploring disconnect between launch time and read time with Karma

twolfson · Jun 18, 2019 · ae93d14 · ae93d14
1 parent 3ee7946
commit ae93d14
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/electron-launcher.js b/lib/electron-launcher.js
@@ -48,8 +48,10 @@ if (program.require) {
 async.parallel([
   function loadExtendedOptions (cb) {
     // If we have extended options, then load them in
+    console.log('hiii', program.extendedOptions);
     if (program.extendedOptions) {
       fs.readFile(program.extendedOptions, function handleReadFile (err, extendedOptionsStr) {
+      console.log('hiii', err, program.extendedOptionsStr);
         // If we have an error, callback with it
         if (err) { return cb(err); }
 

diff --git a/lib/karma-electron-launcher.js b/lib/karma-electron-launcher.js
@@ -33,7 +33,6 @@ function ElectronBrowser(baseBrowserDecorator, args, karmaBasePath, karmaUrlRoot
   //   https://github.com/electron/electron/issues/4218
   // DEV: We write options out now as `_getOptions` is re-run on every start (e.g. crash occurs)
   var extendedOptions;
-  var extendedOptionsFilepath = path.join(this._tempDir, 'karma-electron-options.json');
   if (args.browserWindowOptions) {
     extendedOptions = extendedOptions || {};
     extendedOptions.browserWindowOptions = args.browserWindowOptions;
@@ -59,7 +58,10 @@ function ElectronBrowser(baseBrowserDecorator, args, karmaBasePath, karmaUrlRoot
       // Use temporary directory provided by karma
       //   https://github.com/karma-runner/karma/blob/v4.1.0/lib/launchers/process.js#L15
       // DEV: File will automatically be removed by Karma which is nice
-      fs.writeFileSync(extendedOptionsFilepath, JSON.stringify(extendedOptions), 'utf8');
+      var extendedOptionsFilepath = path.join(this._tempDir, 'karma-electron-options.json');
+      console.log('wtf', fs.writeFileSync + '');
+      fs.writeFileSync(extendedOptionsFilepath, JSON.stringify(extendedOptions));
+      console.log('aaa', fs.readFileSync(extendedOptionsFilepath).toString('utf8'));
       retArr = retArr.concat(['--extended-options', extendedOptionsFilepath]);
     }
     return retArr;