-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[questions] Is Electron 12 supported? #50
Comments
It definitely should be supported. Unsure what's causing that error. Will triage by the end of the weekend |
Thanks, I'd really appreciate it! |
Looking into this now |
I've reproduced
|
When I run in continuous mode ( |
Adding
|
It looks like https://www.electronjs.org/docs/tutorial/context-isolation It does seem related to https://github.com/twolfson/karma-electron/tree/6.3.3#forcing-nodeintegration-support That was regarding a workaround for https://www.electronjs.org/blog/electron-5-0 Digging into my own README now... |
Since we don't set But still pushing people towards using Going to still keep on reading a bit more (maybe play with |
Yea, I think the thought process is:
Going ahead with documentation only |
This has been documented in |
Hmm, I might have spoken too soon -- |
Hmm, yea -- I think missing I'm out of time to dig into this tonight but we do have a workaround for now as documented: // Inside custom launcher
browserWindowOptions: {
webPreferences: {
contextIsolation: false
}
} |
Ahhh thank you so much, reading the example I discovered this was related to the I had one other unrelated problem and I have my unit tests successfully running know 🤗 Thank you for the help! |
Glad to hear that got it working =D Going to leave this issue open as we've still got broken CI to look into |
Started digging into this again, wanted to find out exactly what part of After some digging, saw some It turns out this is part of {
webPreferences: {
nativeWindowOpen: true
}
} which also seems to resolve the issues for a electron/electron#9340 (comment) https://www.electronjs.org/docs/api/window-open#using-chromes-windowopen-implementation Going to more robustly test that setting (maybe even rollback the |
Alright, settled on and updated documentation to better explain 2 getting started mechanisms (non-extended config, Node.js + custom config) |
See for more information twolfson/karma-electron#50
See for more information twolfson/karma-electron#50
karma-electron/package.json
Line 58 in f40ee1e
I was trying to upgrade locally but I ran into this issue.
My release build and local builds works, it's only my unit tests that fail.
I started from a boilerplate but as I understand it, this plugin provides Karma with the ability to test with
require
so hopefully this is a good place to ask.If you have any suggestions that would be appreciated also!
The text was updated successfully, but these errors were encountered: