New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for Python 3.7 #47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately Travis CI doesn't yet support Python 3.7 so the tests are failing =/ I'm happy to land this but I think we'll need to remove 3.7 from .travis.yml
first
I think we can wait a bit for Python 3.7 on travis. It should come soon. |
Cool, works for me. Leaving this PR open until then |
Any updates? |
In theory it should work as Travis CI has 3.7 support, https://docs.travis-ci.com/user/languages/python/, but I'm still seeing errors. It looks like @dotlambda If this is high priority for you, then I'm happy to accept a PR which only updates the library to stop using |
Original patch by Miro Hrončok. See https://bugzilla.redhat.com/show_bug.cgi\?id\=1605884
@twolfson @dotlambda I just updated this PR and travis build passed! |
Great, thanks @Jenselme! Landing this now |
This has been landed in |
You're welcomed! And thanks for your package! |
Original patch by Miro Hrončok. See https://bugzilla.redhat.com/show_bug.cgi\?id\=1605884