Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Python 3.7 #47

Merged
merged 1 commit into from Mar 23, 2019
Merged

add support for Python 3.7 #47

merged 1 commit into from Mar 23, 2019

Conversation

Jenselme
Copy link
Contributor

@Jenselme Jenselme commented Aug 1, 2018

Original patch by Miro Hrončok. See https://bugzilla.redhat.com/show_bug.cgi\?id\=1605884

Copy link
Owner

@twolfson twolfson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately Travis CI doesn't yet support Python 3.7 so the tests are failing =/ I'm happy to land this but I think we'll need to remove 3.7 from .travis.yml first

@Jenselme
Copy link
Contributor Author

Jenselme commented Aug 2, 2018

I think we can wait a bit for Python 3.7 on travis. It should come soon.

@twolfson
Copy link
Owner

twolfson commented Aug 2, 2018

Cool, works for me. Leaving this PR open until then

@dotlambda
Copy link

Any updates?

@twolfson
Copy link
Owner

In theory it should work as Travis CI has 3.7 support, https://docs.travis-ci.com/user/languages/python/, but I'm still seeing errors. It looks like __dir is being picked up as a class-level variable due to its __ prefix and the 3.7 build is failing to compile PyYAML

@dotlambda If this is high priority for you, then I'm happy to accept a PR which only updates the library to stop using __dir__ (e.g. moves to _dir) and passes existing Python versions

@Jenselme
Copy link
Contributor Author

@twolfson @dotlambda I just updated this PR and travis build passed!

@twolfson
Copy link
Owner

Great, thanks @Jenselme! Landing this now

@twolfson twolfson merged commit 5cbf362 into twolfson:master Mar 23, 2019
@twolfson
Copy link
Owner

This has been landed in 1.3.0 and pushed to PyPI. Thanks again!

@Jenselme Jenselme deleted the fix/python-3.7 branch March 24, 2019 10:26
@Jenselme
Copy link
Contributor Author

You're welcomed! And thanks for your package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants