Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial Refunds don't sync over to Civi #9

Closed
josephlacey opened this issue Jun 12, 2019 · 5 comments
Closed

Partial Refunds don't sync over to Civi #9

josephlacey opened this issue Jun 12, 2019 · 5 comments

Comments

@josephlacey
Copy link
Contributor

EventBrite allows partial refunds, in cases where folks might overpay or don't get group discounts. These don't update their correlative Civi record.

@twomice
Copy link
Owner

twomice commented Jun 18, 2019

Hi @josephlacey I'm having trouble reproducing this one on my testing setup. E.g., see attached image, which reflects a $1.00 refund on a $2.70 order:
partial_refund_order_959644437

Can you point me to the order ID on your EB system, for the order that's not properly syncing the refund?

@josephlacey
Copy link
Contributor Author

Interesting. Order# 963617652 should be partially refunded.

twomice added a commit that referenced this issue Jun 18, 2019
Delete can cause links to go away in situations where they're not
re-created, which is of course problematic for updates. E.g., #9.
@twomice
Copy link
Owner

twomice commented Jun 18, 2019

Hi @josephlacey This bad behavior appears actually to be brought out by an edge case when the un-refunded total is small enough that Eventbrite fees go down to zero -- in certain case with very small ticket prices like $2. In any case, the situation did highlight legitimate bugs, and I've made commits to fix those.

So, testing on this fix should use those same small ticket prices.

I'm not able to test immediately on my EB account, due to policies of my payment processor, which require waiting 3-4 business days until payment is resolved, before making a partial refund. Are you able to test this latest code with your EB setup?

@josephlacey
Copy link
Contributor Author

Hi @josephlacey This bad behavior appears actually to be brought out by an edge case when the un-refunded total is small enough that Eventbrite fees go down to zero -- in certain case with very small ticket prices like $2. In any case, the situation did highlight legitimate bugs, and I've made commits to fix those.

Ha, why am I not surprised?

So, testing on this fix should use those same small ticket prices.

I'm not able to test immediately on my EB account, due to policies of my payment processor, which require waiting 3-4 business days until payment is resolved, before making a partial refund. Are you able to test this latest code with your EB setup?

Sure, I can test this. I would say this isn't a launch blocker.

@twomice
Copy link
Owner

twomice commented Jul 2, 2019

Fixed in 54e87d5

@twomice twomice closed this as completed Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants