handle both Activity Email and CiviMail-style token arrays #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first I thought this was a bug in your extension - but it's really a bug in core. Given how long the bug has been in core (2016) I think it makes sense to account for it in the extension - especially since this fix won't need changing if the bug ever IS fixed.
Chris Burgess outlines the issue perfectly in CRM-19758 - essentially, the array passed to this hook as
$tokens
isn't always in the same format. As a result, the tokens this extension generates fail on CiviMail (but not quick email, scheduled reminders, etc.)This adds a helper function (stolen from Chris Burgess) to account for both array formats.
To test:
Create a template with this text: