Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reroll answer #508

Merged
merged 23 commits into from
Jul 1, 2024
Merged

Reroll answer #508

merged 23 commits into from
Jul 1, 2024

Conversation

twonirwana
Copy link
Owner

No description provided.

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 82.76730% with 137 lines in your changes missing coverage. Please review.

Project coverage is 69.20%. Comparing base (e225195) to head (446935b).

Files Patch % Lines
...anno/discord/bot/command/AbstractSlashCommand.java 73.46% 19 Missing and 7 partials ⚠️
...command/AbstractComponentInteractEventHandler.java 83.87% 11 Missing and 9 partials ⚠️
...e/janno/discord/bot/dice/DiceEvaluatorAdapter.java 79.31% 8 Missing and 10 partials ⚠️
...iscord/bot/command/reroll/RerollAnswerHandler.java 88.81% 1 Missing and 15 partials ⚠️
.../de/janno/discord/bot/command/AbstractCommand.java 76.19% 2 Missing and 8 partials ⚠️
.../bot/command/sumCustomSet/SumCustomSetCommand.java 71.42% 0 Missing and 8 partials ⚠️
...discord/bot/command/reroll/RerollAnswerConfig.java 64.28% 2 Missing and 3 partials ⚠️
.../discord/bot/command/reroll/DieIdTypeAndValue.java 66.66% 1 Missing and 3 partials ⚠️
...iscord/bot/persistance/PersistenceManagerImpl.java 76.47% 2 Missing and 2 partials ⚠️
...in/java/de/janno/discord/bot/BaseCommandUtils.java 66.66% 1 Missing and 1 partial ⚠️
... and 20 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #508      +/-   ##
============================================
- Coverage     70.94%   69.20%   -1.75%     
+ Complexity     1283     1067     -216     
============================================
  Files           107      100       -7     
  Lines          5969     5143     -826     
  Branches        593      513      -80     
============================================
- Hits           4235     3559     -676     
+ Misses         1287     1208      -79     
+ Partials        447      376      -71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twonirwana twonirwana merged commit f7425f6 into main Jul 1, 2024
5 of 6 checks passed
@twonirwana twonirwana deleted the rerollAnswer branch July 4, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant