[Bug report] True range not calculated correctly

[WoutGeeurickx]

Hi Kevin,

While experimenting with the many indicators that you have implemented (big thanks for that!), I noticed a mistake in the calculation for the True Range.
I guess pandas_ta/volatility/true_range.py line 61 should be
ranges = [high - low, high - prev_close, prev_close - low]
instead of
ranges = [high - low, high - prev_close, low - prev_close]

Regards,
Wout

[twopirllc]

Hello Wout,

Excellent catch! Thanks for letting me know. I will try and get a fix in soon.

Thank you,
KJ

[atefar2]

hey Kevin the import pandas_ta as ta is acting up

…

On Mon, Mar 16, 2020 at 10:32 AM Kevin Johnson ***@***.***> wrote: Hello Wout, Excellent catch! Thanks for letting me know. I will try and get a fix in soon. Thank you, KJ — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#34 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKS2PFZV7USM44FYLKGUAUTRHZPCHANCNFSM4LJN4SUA> .

-- Amen Tefarie www.amentefarie.com

[twopirllc]

Hello @atefar2,

You need to be more descriptive then, import pandas_ta is acting up. If this not related to the true_range calculation issued above, please open a new issue with a better description and your environment.

Thanks

[twopirllc]

Hello @WoutGeeurickx

Bug has been fixed and updated on Github.

Thanks again,
Kevin