Add anonymized skin name to Sentry error reports. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is suspected that a great many exceptions occur during creation, modification, or general use of custom skins. While arbitrary anonymized skin names cannot be de-anonymized, we can at least determine the anonymized values for SimpleStyle and other well-known skins. And, while the name alone cannot tell us if the user has modified the skin, there is a great deal more likelihood of an actual application issue if we can tell the user is at least running SimpleStyle, under the assumption they've not modified it. If this new Sentry tagging still leaves too much ambiguity in error reports, especially those associated with SimpleStyle, we can add further detail (e.g. a hash of skin file content.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is suspected that a great many exceptions occur during creation,
modification, or general use of custom skins. While arbitrary anonymized
skin names cannot be de-anonymized, we can at least determine the
anonymized values for SimpleStyle and other well-known skins. And, while
the name alone cannot tell us if the user has modified the skin, there
is a great deal more likelihood of an actual application issue if we can
tell the user is at least running SimpleStyle, under the assumption
they've not modified it. If this new Sentry tagging still leaves too
much ambiguity in error reports, especially those associated with
SimpleStyle, we can add further detail (e.g. a hash of skin file
content.)