Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese Language Pack (MS UI Gothic) requirement to README.md and wrapped font exception #44

Merged
merged 1 commit into from Jun 3, 2020

Conversation

twopointzero
Copy link
Owner

@twopointzero twopointzero commented Jun 3, 2020

With the old setup documentation lost to the sands of time, too many automatic error reports describe users encountering missing fonts. And not just missing main fonts but even missing fallback fonts.

This PR:

  • Updates the README.md System Requirements to call out the need for the Japanese Language Pack. (Note that this has for ages been a TJAPlayer3 requirement, hence only bumping patch and not major.)
  • Also adds a similar stated requirement of running in the Japanese System Culture, because why not add that while there. (Note that this too has for ages been a TJAPlayer3 requirement, hence only bumping patch and not major.)
  • Wraps exceptions loading the MS UI Gothic fallback font with a same-typed exception whose Message specifically instructs the user of the need for the Japanese Language Pack (or manual installation of the MS UI Gothic font.)

Fixes TJAPLAYER3-2J

…guage Pack (or manual MS UI Gothic installation.)
@twopointzero twopointzero added the chore Changes unrelated to enhancements or bug fixes label Jun 3, 2020
@twopointzero twopointzero merged commit b8300bf into develop Jun 3, 2020
@twopointzero twopointzero deleted the feature/clarify-fallback-font-requirement branch June 3, 2020 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes unrelated to enhancements or bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant