Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media plugin #8

Open
rburchell opened this issue Sep 22, 2014 · 8 comments
Open

Media plugin #8

rburchell opened this issue Sep 22, 2014 · 8 comments

Comments

@rburchell
Copy link
Contributor

Hi,

Shortly before leaving Jolla, I was working on investigating YTPlayer as a Media application plugin. I have permission to open source this work, but it is not really in a state ready for a pull request.

If you can give me a mail address or something, I'd be happy to send the code (& instructions) there.

BR,
Robin

@michael-k
Copy link

See https://github.com/tworaz/sailfish-ytplayer/blob/master/AUTHORS

But why not push it to a branch in your github fork?

@rburchell
Copy link
Contributor Author

@tworaz
Copy link
Owner

tworaz commented Oct 12, 2014

Hi, the code and the idea certainly look interesting. Unfortunately I currently don't have the time to incorporate this into main branch. I've only recently found the time to finish working on long overdue 0.3.0 release. Still, thank you very much for sharing the code. I think I should have some extra free time in November so I'll cerainly have a better look at it.

@ghost
Copy link

ghost commented Jan 14, 2015

Hi tworaz, has there been any further work on this?

@tworaz
Copy link
Owner

tworaz commented Jan 14, 2015

The honest answer is no. I looked at it a bit after 0.3.0 release, and finally decided I'm not interested in the feature at least for 2-3 next major releases. I have rather limited time to work on the project and I'd rather spend it on more user visible changes like video downloads in 0.4.0, youtube playlists support, comments, search history/suggestions, contextual searches etc.

If you're interested in working on the feature, you're more than welcome to hack on it.

@Thaodan
Copy link
Contributor

Thaodan commented Jan 20, 2015

What is needed to push this to for the current ver?

@tworaz
Copy link
Owner

tworaz commented Jan 21, 2015

You probably can't just push it. The original patch was based on rather old version of YTPLayer. It also moved a lot of code around which I'd rather avoid. What you basically need is to only take the new files the patch added, make sure thay're incorportated into the project, change the project template to build a library instead of an executable. Also you probably need to make sure that the library uses YTPlugin.qml file as entry point instead of YTPlayer.qml.

At least on master qml files are already packaged as resources so you can skip this part of the patch.

@accumulator
Copy link

Anyone looking at this? I'd love to use ytplayer-lib for using it in Quickddit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants