This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
Thread compute cluster through Fenzo #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 7, 2019 08:52
… of getting it via the global.
scrosby
changed the title
pschorf
reviewed
May 9, 2019
| (defn get-default-cluster-name-for-legacy | ||
| "What cluster name to put on for legacy jobs when generating their compute-cluster." | ||
| [] | ||
| @default-cluster-name-for-legacy) |
There was a problem hiding this comment.
Can we get rid of the atom and just have this read the config? This shouldn't change over the lifetime of the process.
There was a problem hiding this comment.
Done. I'll make a parallel change in the new patch. :)
| ; A hack to store the mesos cluster name, until we refactor the code so that we support multiple clusters. In the long term future | ||
| ; this is probably replaced with a function from driver->cluster-id, or the cluster name is propagated by function arguments and | ||
| ; closed over. | ||
| (def mesos-cluster-name-hack (atom nil)) |
There was a problem hiding this comment.
Why do we need this in addition to get-default-cluster-name-for-legacy?
There was a problem hiding this comment.
mesos-cluster-name-hack is a hack that will go away when we restructure the initialization. get-default-cluster-for-legacy will exist forever in order to back-patch a cluster into legacy task structures.
There was a problem hiding this comment.
Ok, I buy that. Same comment as above, though: can we replace the atom with a string read from config?
DaoWen
changed the title
added 2 commits
May 10, 2019 15:04
pschorf
approved these changes
May 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
Why are we making these changes?
This ensures that the compute cluster is attached to the offer, an enabling refactor for supporting more than one cluster. Now we know to whom to send the response.