Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazily instantiate codemirror instances #1615

Merged
merged 3 commits into from May 18, 2015
Merged

Lazily instantiate codemirror instances #1615

merged 3 commits into from May 18, 2015

Commits on May 18, 2015

  1. Lazily instantiate codemirror instances 

    By taking advantage of the fact that a user can not interact
with codemirror instance until they are in the viewport, we can be
smart and only set the codemirror editors up once a user scrolls them into view.

For small notebooks this change has a limited impact, however for large
notebooks with 100s of code cells this change results in a significant
performance boost to the application, especially in the initial time to
render metric for notebooks.

ref #1546
Fixes #178
    @samccone
    samccone committed May 18, 2015
    Copy the full SHA
    632880f View commit details
    Browse the repository at this point in the history

  2. Add requestAnimatationFrame polyfill

    @samccone
    samccone committed May 18, 2015
    Copy the full SHA
    206d232 View commit details
    Browse the repository at this point in the history

  3. Style uninstantiated codecells to match codemirror.

    @samccone
    samccone committed May 18, 2015
    Copy the full SHA
    16fff29 View commit details
    Browse the repository at this point in the history