Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6410 implement %%javascript magic for rendering the application/javascript mime #6482

Merged
merged 5 commits into from Dec 11, 2017

Conversation

MariuszJurowicz
Copy link
Contributor

This has to be tested heavily.
We don't have the requirejs on the jupyterlab yet.

@scottdraves
Copy link
Contributor

this works great but i am not sure i understand the new build requirements.
i had to run "npm install && npm run build".

  1. why is a new build step required, we already have a "yarn install" run to compile this, right?
  2. can we stick with yarn instead of npm?
  3. whatever it is, this stuff has to be included into our regular build scripts before i can merge.

@jmsdnns
Copy link
Contributor

jmsdnns commented Dec 8, 2017

  1. npm run build is an alias for npm build, and it does nothing unless you specify what "build" does in your package.json file, which bfe75da now does.

  2. yarn build and npm build are supposed to be equivalent.

@MariuszJurowicz
Copy link
Contributor Author

The separate build for the Lab extension is just the transpilation of the TypeScript sources to the js output. It can be done via npm or yarn but as this is published as the separate package i don't want to add an extra env requirements on the build process (just node and npm). The current approach lets developers change the sources and build the extension for themselves without depending on the beakerx notebook extension. But I think there are no obstacles to the running this build together with the beakerx notebook extension build.

@MariuszJurowicz
Copy link
Contributor Author

MariuszJurowicz commented Dec 11, 2017

@scottdraves i've added the prepublish scripts so that you cand do just the npm publish and the npm will run the yarn build:prod for you before publishing to npm.
Also the build for lab is executed after the notebook build.

@scottdraves scottdraves merged commit c29502a into master Dec 11, 2017
michalgce added a commit that referenced this pull request Dec 12, 2017
* origin/master:
  removing error message from stdout in test + test refactoring (#6480)
  #6479 add readme to find start of documentation
  #6479 - fixed doc file names to match camel case (#6488)
  #6429 Added jupyterlab and jupyterhub. (#6472)
  Spot/6483 (#6485)
  #6410 implement %%javascript magic for rendering the `application/javascript` mime (#6482)

# Conflicts:
#	docker/setup.sh
michalgce added a commit that referenced this pull request Dec 12, 2017
* origin/master:
  removing error message from stdout in test + test refactoring (#6480)
  #6479 add readme to find start of documentation
  #6479 - fixed doc file names to match camel case (#6488)
  #6429 Added jupyterlab and jupyterhub. (#6472)
  Spot/6483 (#6485)
  #6410 implement %%javascript magic for rendering the `application/javascript` mime (#6482)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants