Fix git-meta rm path overmatching issue #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novalis
reviewed
Nov 9, 2018
shijinglu
commented
Nov 9, 2018
| @@ -38,7 +38,6 @@ const NodeGit = require("nodegit"); | |||
|
|
|||
| const Checkout = require("./checkout"); | |||
| const CherryPickUtil = require("./cherry_pick_util"); | |||
| const Commit = require("./commit"); | |||
There was a problem hiding this comment.
removed according to jslint
novalis
approved these changes
Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently running
git meta rm -rf abcmatches following directories which should not have:The issue is because
getSubmodulesInPathin thesubmodule_utils.jshas a bug: it thinks if x.startsWith(y) than x must be a subdirectory of y. This is not true asabcd/ef/starts withabc, but it is not a subdirectory of the later.I changed to logic to:
startsWithis sufficientxfrom y, the rest of y should starts with a leading/.