Skip to content
This repository has been archived by the owner on Mar 22, 2023. It is now read-only.

Swap use -> require in resolve-symbol helper #474

Merged
merged 2 commits into from Oct 12, 2018
Merged

Swap use -> require in resolve-symbol helper #474

merged 2 commits into from Oct 12, 2018

Conversation

DaoWen
Copy link
Contributor

@DaoWen DaoWen commented Oct 11, 2018

Changes proposed in this PR

Use require rather than symbol for our our dynamic "class-loading" logic in the resolve-symbol helper (the function that we use for loading :factory-fns for Waiter components.)

Why are we making these changes?

Since use imports all members into the current namespace, that was causing errors when we use the waiter.auth.kerberos namespace twice: once for Authentication, and once for Authorization. The conflicts were causing fatal errors on Waiter startup.

@DaoWen DaoWen added the wip label Oct 11, 2018
@DaoWen DaoWen removed the wip label Oct 12, 2018
@DaoWen DaoWen requested a review from shamsimam October 12, 2018 19:28
@shamsimam shamsimam merged commit 0cf84fc into twosigma:master Oct 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants