This repository has been archived by the owner on Mar 22, 2023. It is now read-only.
Swap use -> require in resolve-symbol helper #474
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
Use
require
rather thansymbol
for our our dynamic "class-loading" logic in theresolve-symbol
helper (the function that we use for loading:factory-fn
s for Waiter components.)Why are we making these changes?
Since
use
imports all members into the current namespace, that was causing errors when weuse
thewaiter.auth.kerberos
namespace twice: once forAuthentication
, and once forAuthorization
. The conflicts were causing fatal errors on Waiter startup.